[Asterisk-code-review] media_cache: Don't lock when curl the remote file (asterisk[master])

[Andre Barbosa]

Attention is currently required from: Kevin Harwell.
Andre Barbosa has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16233 )

Change subject: media_cache: Don't lock when curl the remote file
......................................................................


Patch Set 2:

(3 comments)

File main/media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/16233/comment/3c83b5fd_6f66af85 
PS1, Line 192: 	// we unlock to curl the file
> Coding guidelines: Don't use C++ type e.g. […]
Fixed, thanks!


https://gerrit.asterisk.org/c/asterisk/+/16233/comment/4b0fb8b5_3654b724 
PS1, Line 204: 	//we lock again, before updating cache
> Use /* */ style comment here too
Fixed, thanks!


https://gerrit.asterisk.org/c/asterisk/+/16233/comment/54186366_77936c2a 
PS1, Line 210: 	if (ast_media_cache_exists(uri)) {
> While this call should be okay it 1) locks the cache again (but lock should be re-entrant so fine) 2 […]
Changed. Thanks!



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16233
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408
Gerrit-Change-Number: 16233
Gerrit-PatchSet: 2
Gerrit-Owner: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 14:02:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210816/58c0835b/attachment-0001.html>