[Asterisk-code-review] app_mf: Add channel agnostic MF sender (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A, Joshua Colp, Sarah Autumn, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16080 )

Change subject: app_mf: Add channel agnostic MF sender
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

File apps/app_mf.c:

https://gerrit.asterisk.org/c/asterisk/+/16080/comment/7e48fc67_96e7cc62 
PS8, Line 287: 		return -1;
chan_found is potentially leaked here.


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/d8b75935_54c1c788 
PS8, Line 295: 	if (chan_found) {
             : 		ast_channel_unref(chan_found);
             : 	}
There is an ast_channel_cleanup macro that checks for NULL first as you are doing here if you'd rather use that.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 8
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 16:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210813/b48e2122/attachment.html>