[Asterisk-code-review] app_milliwatt: Timing fix (asterisk[master])

N A asteriskteam at digium.com
Fri Aug 13 09:14:59 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16238 )

Change subject: app_milliwatt: Timing fix
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> The existing behavior has existed for almost 22 years. Suddenly changing it is not acceptable. […]
That's why I suggested changing it then for Asterisk 19, since it's acceptable to change things like that for new standard releases. The existing erroneous behavior could be retained for the existing LTS versions.

A lot of people have not been using Milliwatt() for Milliwatt tests, since it's never worked properly. That's just the thing. I myself do not use Milliwatt for my milliwatt tests, since the existing Milliwatt() is useless. It just seems to work to laypeople with no understanding of the actual technical specifications to which such things are supposed to adhere. Milliwatt() is not a real milliwatt.

Various telephone people have griped about this many times and pointed out the wrong behavior in telephone circles. These are telephone engineers, many retired from the Bell System, not programmers, so they're not really involved with technical stuff like posting on JIRA or Gerrit. If you need other anecdotes, I can get them for you or try to have people comment on the issue. But in order for this bug fix to be effective, everyone using Milliwatt would be required to update their dialplan - I would do it, but most people are probably going to lose track of that.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16238
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I73ccc6c6fcaa31931c6fff3b85ad1805b2ce9d8c
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 14:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210813/d891536c/attachment.html>


More information about the asterisk-code-review mailing list