[Asterisk-code-review] app_milliwatt: Timing fix (asterisk[master])

N A asteriskteam at digium.com
Fri Aug 13 09:02:49 CDT 2021


Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16238 )

Change subject: app_milliwatt: Timing fix
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> > Even though the default behavior is incorrect? […]
Except it was already broken, and this is fixing it to the way it should have been in the first place.

Maybe starting in Asterisk 19, we can ditch the asinine default and make the correct behavior the default, at least?

I guess we gotta do what we gotta do, but Milliwatt() is a false advertisement at best at present and requiring an option to make it work properly doesn't really make sense to me. Numerous people have complained about how "Milliwatt in Asterisk is broken and useless" and I'm sure would be very glad to see this fixed, without additional effort on their part.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16238
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I73ccc6c6fcaa31931c6fff3b85ad1805b2ce9d8c
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 14:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210813/f8a40d35/attachment.html>


More information about the asterisk-code-review mailing list