[Asterisk-code-review] sig_analog: Changes to improve electromechanical signalling compatibi... (asterisk[master])

[Sarah Autumn]

Attention is currently required from: Sean Bright, Joshua Colp, Kevin Harwell.
Sarah Autumn has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16151 )

Change subject: sig_analog: Changes to improve electromechanical signalling compatibility
......................................................................


Patch Set 5:

(2 comments)

Patchset:

PS4: 
> Dunno much about about the backing protocol, but generally speaking looks good to me. […]
Thanks Kevin. Can't speak for my coding skills, but as for the ANI protocol, we have the original source documents from 1962, and we've tested this on the original electromechanical hardware it was designed for, so there's that, at least ;-)


File channels/chan_dahdi.h:

https://gerrit.asterisk.org/c/asterisk/+/16151/comment/f9df7bc4_f008d65f 
PS3, Line 196: 	 * \brief INTEGER, length of time to wait before sending ANI wink in ms. 
> Up to you whether you fix it now or later. […]
done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
Gerrit-Change-Number: 16151
Gerrit-PatchSet: 5
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 01:07:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Sarah Autumn <sarah at endlesstemple.org>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210809/b843a049/attachment.html>