[Asterisk-code-review] app_dial: Prevent call from hanging (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15985 )

Change subject: app_dial: Prevent call from hanging
......................................................................


Patch Set 2:

(1 comment)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15985/comment/4b6237f3_6f2fbbbb 
PS2, Line 1802: 						if (ast_check_hangup_locked(o->chan)) {
> I guess I mean the chan that o->chan is, not o->chan itself. […]
The issue is that it hasn't been explained precisely why it's the correct fix. It's an assumption so far based on the analysis, but there hasn't been an explanation of why the existing logic is truly failing.

The existing logic works for the non-DTMF/non-MF case so it does work, thus it has to be explained either why this new check has to be added for that case (and referencing why the existing logic precisely doesn't work).

For example: Is it possible that the hangup is being handled and ignored elsewhere? If so then the channel would never have any activity on it, resulting in app_dial never looking at the channel again and never seeing it as hung up.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15985
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6f2ee3f77b892015bc05513d868f071f279a3c80
Gerrit-Change-Number: 15985
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 22:46:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210806/b3a80745/attachment-0001.html>