[Asterisk-code-review] func_sayfiles: Retrieve say file names (asterisk[master])

N A asteriskteam at digium.com
Fri Aug 6 13:10:08 CDT 2021


Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16226 )

Change subject: func_sayfiles: Retrieve say file names
......................................................................


Patch Set 11:

(4 comments)

File funcs/func_sayfiles.c:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/ea55cec2_8f75781e 
PS9, Line 67: 						<para>Files played by SayMoney().</para>
> Currently supported for English and US Dollars only.
Done


https://gerrit.asterisk.org/c/asterisk/+/16226/comment/3f50648a_869d57ac 
PS9, Line 75: 			playback of multiple ampersand-delimited files.</para>
> An example would be nice.
Done


File main/pbx_builtins.c:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/565a2e9b_55ce17b9 
PS9, Line 524: This application will play the sounds that correspond to the dollar(s)
             : 			and cent(s) of the given floating point number
> This application will play the currency sounds for the given floating point number in the current la […]
Done


File main/say.c:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/b5cc7f5a_f7178912 
PS9, Line 363: ast_get_money_str
> You need to do the same thing here as for number. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16226
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If9718c89353b8e153d84add3cc4637b79585db19
Gerrit-Change-Number: 16226
Gerrit-PatchSet: 11
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 18:10:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210806/1ff44e6f/attachment.html>


More information about the asterisk-code-review mailing list