[Asterisk-code-review] app_morsecode: Add American Morse code (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16230 )

Change subject: app_morsecode: Add American Morse code
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File apps/app_morsecode.c:

https://gerrit.asterisk.org/c/asterisk/+/16230/comment/efe3b9c8_40d22ddf 
PS3, Line 64: MORSEOFF
> I renamed it "MORSEOFFPITCH" - "OFFSET" sounds like offset (as in an offset to the frequency), which isn't what this is, so could be confusing.

Ha!  That's what I thought it was.  How about MORSESPACETONE then to make it like MORSETONE.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16230
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I172431a2e18e6527d577e74adfb05b154cba7bd4
Gerrit-Change-Number: 16230
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 17:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210806/f47c2752/attachment.html>