[Asterisk-code-review] func_sayfiles: Retrieve say file names (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16226 )

Change subject: func_sayfiles: Retrieve say file names
......................................................................


Patch Set 9: Code-Review-1

(4 comments)

File funcs/func_sayfiles.c:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/f8df4312_335d1fc0 
PS9, Line 67: 						<para>Files played by SayMoney().</para>
Currently supported for English and US Dollars only.


https://gerrit.asterisk.org/c/asterisk/+/16226/comment/18bf25e7_be2b35b1 
PS9, Line 75: 			playback of multiple ampersand-delimited files.</para>
An example would be nice.


File main/pbx_builtins.c:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/d65df338_f51686cd 
PS9, Line 524: This application will play the sounds that correspond to the dollar(s)
             : 			and cent(s) of the given floating point number
This application will play the currency sounds for the given floating point number in the current language.  Currently only English and US Dollars is supported.


File main/say.c:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/9f4db138_50eb8c0a 
PS9, Line 363: ast_get_money_str
You need to do the same thing here as for number.  rename this to an internal function and have the public function error for language other than english.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16226
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If9718c89353b8e153d84add3cc4637b79585db19
Gerrit-Change-Number: 16226
Gerrit-PatchSet: 9
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 17:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210806/8313a3d4/attachment.html>