[Asterisk-code-review] func_sayfiles: Retrieve say file names (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16226 )

Change subject: func_sayfiles: Retrieve say file names
......................................................................


Patch Set 8:

(2 comments)

File funcs/func_sayfiles.c:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/c300d5c9_599668e2 
PS8, Line 67: SayMoney()
> So where is this SayMoney() application? 😊
It's in say.c.


File include/asterisk/say.h:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/d383f0ae_6e09e44d 
PS8, Line 146:  * function to pronounce monetary amounts
             :  */
             : int ast_say_money_str(struct ast_channel *chan, const char *num,
             : 	const char *ints, const char *lang);
             : 
             : SAY_EXTERN int (* ast_say_money_str_full)(struct ast_channel *chan, const char *num, const char *ints, const char *lang, int audiofd, int ctrlfd) SAY_INIT(ast_say_money_str_full);
             : 
> Remove for now and add it when you have the complete implementation including the SayMoney() applica […]
I'm a bit confused, what's incomplete about the SayMoney app currently? Or just shouldn't be here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16226
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If9718c89353b8e153d84add3cc4637b79585db19
Gerrit-Change-Number: 16226
Gerrit-PatchSet: 8
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 15:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210806/4f9d28f3/attachment.html>