[Asterisk-code-review] app_originate: Add ability to set codecs (asterisk[master])

N A asteriskteam at digium.com
Thu Aug 5 08:22:56 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16232 )

Change subject: app_originate: Add ability to set codecs
......................................................................


Patch Set 3:

(3 comments)

File apps/app_originate.c:

https://gerrit.asterisk.org/c/asterisk/+/16232/comment/c715f972_3e11c35e 
PS2, Line 204: 	ast_format_cap_append(capabilities, ast_format_slin, 0);
> Such a change needs to be documented, I think it would be okay but it's still a substantial differen […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16232/comment/745e2d79_7ade8a8e 
PS2, Line 204: 	ast_format_cap_append(capabilities, ast_format_slin, 0);
> Such a change needs to be documented, I think it would be okay but it's still a substantial differen […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16232/comment/fffc6062_bd323bc1 
PS2, Line 262: 			ast_format_cap_update_by_allow_disallow(capabilities, opt_args[OPT_ARG_CODECS], 1);
> On line 204 it would still add slin to the capabilities. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16232
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I96a1aeb83d54b635b7a51e1b4680f03791622883
Gerrit-Change-Number: 16232
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 13:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/1dd772eb/attachment.html>


More information about the asterisk-code-review mailing list