[Asterisk-code-review] logger: Add custom logging capabilities (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16222 )

Change subject: logger: Add custom logging capabilities
......................................................................


Patch Set 6:

(7 comments)

File configs/samples/logger.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/fa0cfeeb_34e1bb9b 
PS5, Line 89: ; be sent to logging channels. The maximum number of dynamic
> Dynamic levels is an internal concept that a user may not know. […]
Done


File doc/CHANGES-staging/logger.txt:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/d5cf3921_e6460946 
PS5, Line 3: Adds the ability for custom dynamic logging
> Stick to custom logging levels.
Done


File include/asterisk/logger.h:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/14a8d7fe_805e083a 
PS5, Line 336:  * \retval non-zero negative to be used with ast_log_dynamic_level for sending messages to this level
> I don't understand this, non-zero negative? What happens with zero? -1 is a non-zero negative as wel […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16222/comment/f4611cd1_788e3c6a 
PS5, Line 338: int ast_dynamic_logger_level(const char *name);
> This should be ast_logger_dynamic_level to match the API naming scheme already present.
Done


File main/logger.c:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/af8cf967_e2c4c928 
PS5, Line 819: 			char *customlog = ast_strdup(logfile);
> Why does this need to be duplicated? logger_register_level internally duplicates and stores it. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16222/comment/bd6be57d_86ef4d21 
PS5, Line 2505: 	unsigned int available = 0;
> You've defined this as an unsigned int, but logger_register_level returns an int.
Done


https://gerrit.asterisk.org/c/asterisk/+/16222/comment/f4ec6011_ab0e8b83 
PS5, Line 2519: 	AST_RWLIST_WRLOCK(&logchannels);
> This can be a RDLOCK as it is only reading.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16222
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If082703cf81a436ae5a565c75225fa8c0554b702
Gerrit-Change-Number: 16222
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/9b225c67/attachment-0001.html>