[Asterisk-code-review] app_originate: Add ability to set codecs (asterisk[master])

N A asteriskteam at digium.com
Thu Aug 5 07:49:28 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16232 )

Change subject: app_originate: Add ability to set codecs
......................................................................


Patch Set 2:

(1 comment)

File apps/app_originate.c:

https://gerrit.asterisk.org/c/asterisk/+/16232/comment/22050516_8b1c7021 
PS2, Line 262: 			ast_format_cap_update_by_allow_disallow(capabilities, opt_args[OPT_ARG_CODECS], 1);
> The AMI Originate defaults to slin, if codecs are specified then all are removed (slin), and what is […]
Wouldn't that require that a specific codec always be specified though?
Or am I misunderstanding how the default works?
include/asterisk/format_cap.h:  AST_FORMAT_CAP_FLAG_DEFAULT = 0,



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16232
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I96a1aeb83d54b635b7a51e1b4680f03791622883
Gerrit-Change-Number: 16232
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:49:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/19645a4c/attachment.html>


More information about the asterisk-code-review mailing list