[Asterisk-code-review] app_originate: Add ability to set codecs (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16232 )

Change subject: app_originate: Add ability to set codecs
......................................................................


Patch Set 2:

(1 comment)

File apps/app_originate.c:

https://gerrit.asterisk.org/c/asterisk/+/16232/comment/37ee114c_06bfc5db 
PS2, Line 262: 			ast_format_cap_update_by_allow_disallow(capabilities, opt_args[OPT_ARG_CODECS], 1);
> That behavior is also counter to how the AMI Originate works. […]
What I see there is:
struct ast_format_cap *cap = ast_format_cap_alloc(AST_FORMAT_CAP_FLAG_DEFAULT);
...
if (!ast_strlen_zero(codecs)) {
	ast_format_cap_remove_by_type(cap, AST_MEDIA_TYPE_UNKNOWN);
	ast_format_cap_update_by_allow_disallow(cap, codecs, 1);
}

I wasn't sure as it seemed like it was setting a default, but then removing a placeholder.

Would it be fine to add to slin, or should I make it match what AMI is doing here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16232
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I96a1aeb83d54b635b7a51e1b4680f03791622883
Gerrit-Change-Number: 16232
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/83e3acd5/attachment-0001.html>