[Asterisk-code-review] app_sendmf: New SendMF application (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Sarah Autumn, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16080 )

Change subject: app_sendmf: New SendMF application
......................................................................


Patch Set 4:

(8 comments)

File apps/app_sendmf.c:

https://gerrit.asterisk.org/c/asterisk/+/16080/comment/125f1b0d_f5d40ade 
PS2, Line 232: 	if (peer && ast_autoservice_start(peer)) {
> > To be completely frank, I don't know. […]
Ack


File apps/app_sendmf.c:

https://gerrit.asterisk.org/c/asterisk/+/16080/comment/b9abf3e3_5c1e7372 
PS3, Line 131:  ast_
> Remove the ast_ since this isn't a public function. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/a21a081c_6b721d2f 
PS3, Line 147: ast_senddigit_external_m
> Remove the ast_ since this isn't a public function. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/411eeb74_25dc246e 
PS3, Line 163: tatic int external_sleep(struct ast_channel *chan, int ms)
             : {
             : 	usleep(ms * 1000);
             : 	return 0;
             : }
> This function was copied from app_senddtmf but is unused here because you didn't implement the AMI c […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/35e0f9e7_0191cc92 
PS3, Line 169: tatic int mf_stream(struct ast_channel *chan, const char *digits, int between, unsigned int duration, unsigned int durationkp, unsigned int durationst, int is_external)
> The line should also be wrapped.
Done


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/e15991fd_bbb3d647 
PS3, Line 177: if (is_external) {
             : 		my_sleep = external_sleep;
             : 		my_senddigit = ast_senddigit_external_mf;
> This was copied from app_senddtmf but is unused here because you didn't implement the AMI call. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/6134f526_fb89d580 
PS3, Line 207: DTMF
> MF
Done


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/3e91c558_b75521bf 
PS3, Line 228: static int ast_mf_stream(struct ast_channel *chan, struct ast_channel *peer, const char *digits, int between, unsigned int duration, unsigned int durationkp, unsigned int durationst)
> Remove the ast_ since this isn't a public function. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 04 Aug 2021 14:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210804/c034887d/attachment-0001.html>