[Asterisk-code-review] func_frame_drop: New function (asterisk[master])

N A asteriskteam at digium.com
Mon Aug 2 13:54:55 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16071 )

Change subject: func_frame_drop: New function
......................................................................


Patch Set 9:

(2 comments)

File funcs/func_frame_drop.c:

https://gerrit.asterisk.org/c/asterisk/+/16071/comment/36cd51ad_a950664c 
PS8, Line 82: 					<enum name = "TRANSFER" />
> TRANSFER should also be removed. It's an internal implementation detail of app_transfer. […]
Done


File funcs/func_framedrop.c:

https://gerrit.asterisk.org/c/asterisk/+/16071/comment/1d446d20_cbc9a14c 
PS2, Line 67: 					<enum name = "HANGUP" />
> I was more referring to in the context of this functionality, not in a global sense. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16071
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8147c9d55d74e2e48861edba6b22f930920541ec
Gerrit-Change-Number: 16071
Gerrit-PatchSet: 9
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 02 Aug 2021 18:54:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210802/a3cc1cdd/attachment-0001.html>


More information about the asterisk-code-review mailing list