[Asterisk-code-review] func_lookup: Fork of HINT function (asterisk[master])

N A asteriskteam at digium.com
Mon Aug 2 12:28:03 CDT 2021


Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_lookup: Fork of HINT function
......................................................................


Patch Set 9:

(1 comment)

Patchset:

PS9: 
> I think there are existing ways to do this... The one that comes to mind immediately is […]
I haven't done anything with Lua before, but I'm not sure why that would be needed over dialplan for the example shown, and this doesn't meet the main objective of the patch which is a *function*. Gosub is off-limits since it's clunky at best with the intended use cases. For instance, say you want to pass five lookups into an application without first saving them as variables. This is not possible when Gosub becomes involved.

EVAL will also parse EXTEN as the extension of the calling context, not the called context, making EVAL unsuitable as well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 9
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 02 Aug 2021 17:28:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210802/de80ae44/attachment.html>


More information about the asterisk-code-review mailing list