[Asterisk-code-review] res_pjsip_messaging: Refactor outgoing URI processing (asterisk[18])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15806 )

Change subject: res_pjsip_messaging: Refactor outgoing URI processing
......................................................................


Patch Set 2:

(5 comments)

https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@270 
PS2, Line 270: 				ast_debug(3, "Dest: FAIL: '%s' Found endpoint '%s' but didn't find an aor/contact for it\n",
> Maybe make this an actual error message?
Done


https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@273 
PS2, Line 273: 				ao2_cleanup(contact);
             : 				*uri = ast_strdup(contact->uri);
> Copy the contact's uri before cleanup on the off chance cleanup frees contact.
Heh, I caught the one further down but missed this one.


Done


https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@306 
PS2, Line 306: 			ast_debug(3, "Dest: '%s' FAIL: Didn't find endpoint with name '%s' before the slash\n",
> Similarly maybe make this log an error vs debug too?
Done


https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@344 
PS2, Line 344: 					ast_debug(3, "Dest: '%s' FAIL: Found endpoint '%s' but didn't find contact for aor '%s'\n",
> debug to error?
Done


https://gerrit.asterisk.org/c/asterisk/+/15806/2/res/res_pjsip_messaging.c@391 
PS2, Line 391: 				ast_debug(3, "Dest: '%s' FAIL: Found endpoint '%s' but didn't find contact\n",
> make an error log?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I67a485196d9199916468f7f98bfb9a0b993a4cce
Gerrit-Change-Number: 15806
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 13:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210429/dd31b73a/attachment.html>