[Asterisk-code-review] res_pjsip_header_funcs: Add PJSIP_HEADERS() ability to read header by... (asterisk[master])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15761 )

Change subject: res_pjsip_header_funcs: Add PJSIP_HEADERS() ability to read header by pattern
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c 
File res/res_pjsip_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@288 
PS3, Line 288: 	si
The function pjsip_hdr_print_on returns int, not size_t


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@370 
PS3, Line 370: 	si
The function pjsip_hdr_print_on returns int, not size_t


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@406 
PS3, Line 406: 	p
1. The size of the buffer should be data->len - 1
2. Need to check pj_hdr_string_len != -1, as pjsip_hdr_print_on returns -1 if there's not enough space.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15761
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic09d395de71a0021e0d6c5c29e1e19d689079f8b
Gerrit-Change-Number: 15761
Gerrit-PatchSet: 3
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 19:15:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210427/58445458/attachment-0001.html>