[Asterisk-code-review] res_pjsip_dialog_info_body_generator: Include LOCAL/REMOTE tags in BL... (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15763 )

Change subject: res_pjsip_dialog_info_body_generator: Include LOCAL/REMOTE tags in BLF NOTIFY XML
......................................................................


Patch Set 6: Code-Review-1

(3 comments)

Just minor comments.

https://gerrit.asterisk.org/c/asterisk/+/15763/6//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15763/6//COMMIT_MSG@7 
PS6, Line 7: res_pjsip_dialog_info_body_generator: Include LOCAL/REMOTE tags in BLF NOTIFY XML
Your commit message lines are quite long and surpass the normal, please manually break them up.


https://gerrit.asterisk.org/c/asterisk/+/15763/6//COMMIT_MSG@21 
PS6, Line 21: modified:   res/res_pjsip_dialog_info_body_generator.c
this isn't needed


https://gerrit.asterisk.org/c/asterisk/+/15763/6/doc/CHANGES-staging/res_pjsip_dialog_info_body_generator.txt 
File doc/CHANGES-staging/res_pjsip_dialog_info_body_generator.txt:

https://gerrit.asterisk.org/c/asterisk/+/15763/6/doc/CHANGES-staging/res_pjsip_dialog_info_body_generator.txt@3 
PS6, Line 3: Added functionality to iterate through the channels that are currently ringing,
>From a user perspective this isn't descriptive enough. It needs more information about what this actually does for users. For example: "inserts that info into NOTIFY packet sent to the endpoint so on supported devices the callerid information of who is calling the extension is displayed".



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15763
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I20c5cf5b45f34d7179df6573c5abf863eb72964b
Gerrit-Change-Number: 15763
Gerrit-PatchSet: 6
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Tue, 20 Apr 2021 10:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210420/1f7a9c4d/attachment.html>