[Asterisk-code-review] res_pjsip_dialog_info_body_generator: Include LOCAL/REMOTE tags in BL... (asterisk[18])

Joe asteriskteam at digium.com
Wed Apr 14 14:11:01 CDT 2021


Hello Joshua Colp, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/15781

to look at the new patch set (#3).

Change subject: res_pjsip_dialog_info_body_generator: Include LOCAL/REMOTE tags in BLF NOTIFY XML
......................................................................

res_pjsip_dialog_info_body_generator: Include LOCAL/REMOTE tags in BLF NOTIFY XML

PJSIP endpoints subscribed to BLF notifications will not receive Caller ID
information for the channel ringing on the remote extension.  <remote> and <local> tags
of the dialog are missing completely.

This patch iterates through the channels that are currently ringing, and inserts that info
into the NOTIFY packet so that information is properly passed to the endpoint in dialog-info+xml.

ASTERISK-24601
Patch submitted: Joshua Elson
Tested by: Joseph Nadiv and Sean Bright
Modified by: Joseph Nadiv and Sean Bright

modified:   res/res_pjsip_dialog_info_body_generator.c

Change-Id: I20c5cf5b45f34d7179df6573c5abf863eb72964b
---
A doc/CHANGES-staging/res_pjsip_dialog_info_body_generator.txt
M res/res_pjsip_dialog_info_body_generator.c
2 files changed, 91 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/81/15781/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I20c5cf5b45f34d7179df6573c5abf863eb72964b
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 3
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210414/7ce22d94/attachment.html>


More information about the asterisk-code-review mailing list