[Asterisk-code-review] res_pjsip_pubsub: Include LOCAL/REMOTE tags in BLF NOTIFY XML (asterisk[16])

[Joe]

Joe has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15763 )

Change subject: res_pjsip_pubsub: Include LOCAL/REMOTE tags in BLF NOTIFY XML
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15763/1/res/res_pjsip_dialog_info_body_generator.c 
File res/res_pjsip_dialog_info_body_generator.c:

https://gerrit.asterisk.org/c/asterisk/+/15763/1/res/res_pjsip_dialog_info_body_generator.c@207 
PS1, Line 207: 			need = strlen(connected_num) + (connected_num_restricted ? strlen(invalid) :
> if need exceeds PJSIP_MAX_URL_SIZE for some reason then this would actually cause a buffer overflow, […]
snprintf(remote_target, sizeof(remote_target), "sip:%s@%s", connected_num,
				connected_num_restricted ? invalid : from_domain);

I have to compile and test that, but since we haven't set remote_target yet I don't know fully how that would work.  Can we use [PJSIP_MAX_URL_SIZE] directly here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15763
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I20c5cf5b45f34d7179df6573c5abf863eb72964b
Gerrit-Change-Number: 15763
Gerrit-PatchSet: 2
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 14 Apr 2021 18:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210414/5f915b3b/attachment-0001.html>