[Asterisk-code-review] res_pjsip_messaging: Allow setting domain of recipient (asterisk[18])

[Yang Chen]

Yang Chen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15597 )

Change subject: res_pjsip_messaging: Allow setting domain of recipient
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review-1
> 
> After reviewing the existing code and running some tests, I've determined the following...
> If you construct your MessageSend like
> MessageSend(pjsip:sip:myproviderendpoint/sip:7205551212 at somedomain.com,7205559999 at mypbx1.net)
> The message WILL be sent with both a RequestURI and a To header of sip:7205551212 at somedomain.com.
> Having said that, the way the code is written, 'somedomain.com' is also used as the destination contact instead of the contact associated with the endpoint/aor so the actual MESSAGE message is actually sent to 'somedomain.com'.  Personally, I think that's weird but if that works for you, you don't need this review.  If that doesn't work for you, then I'd consider making get_outbound_endpoint() and msg_send() do the "right" thing.  I.E. use the URI to set the To header but DON'T use that URI as the destination contact.

Hi, George,
Yet another new patch solved this problem you mentioned, please take a review on https://gerrit.asterisk.org/c/asterisk/+/15727 once it finish automation.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15597
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I26fb8605d7cb200332a0442879fd9a5679a65022
Gerrit-Change-Number: 15597
Gerrit-PatchSet: 3
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Yang Chen <yang.chen at linuxe.org>
Gerrit-Comment-Date: Wed, 07 Apr 2021 10:34:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210407/4889526c/attachment-0001.html>