[Asterisk-code-review] bridge_channel_write_frame: Check for NULL channel (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15726 )

Change subject: bridge_channel_write_frame: Check for NULL channel
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15726/1/main/bridge_channel.c 
File main/bridge_channel.c:

https://gerrit.asterisk.org/c/asterisk/+/15726/1/main/bridge_channel.c@661 
PS1, Line 661: 	if (bridge_channel->chan && ast_channel_is_multistream(bridge_channel->chan)) {
> Is it possible for bridge_channel->chan to changed during this? The bridge channel lock isn't held, so does the bridge lock protect it?

Yeah...no.  Although bridge_channel->chan only gets set to NULL with the bridge_channel locked but in those places, the bridge lock isn't held.  I'll have to move the existing bridge_channel lock to happen before the multistream test.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15726
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idfe62dbea8c69813ecfd58e113a6620dc42352ce
Gerrit-Change-Number: 15726
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 13:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210402/bf0ab086/attachment.html>