[Asterisk-code-review] res_pjsip/pjsip_message_filter: set preferred transport in pjsip_mess... (asterisk[16])

[Bernd Zobl]

Bernd Zobl has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15630 )

Change subject: res_pjsip/pjsip_message_filter: set preferred transport in pjsip_message_filter
......................................................................


Patch Set 4:

(1 comment)

> Patch Set 4: Code-Review-1
> 
> I'm going to mark this -1 as it is a substantial behavior change at the moment.

Agreed.

https://gerrit.asterisk.org/c/asterisk/+/15630/4/res/res_pjsip/pjsip_message_filter.c 
File res/res_pjsip/pjsip_message_filter.c:

https://gerrit.asterisk.org/c/asterisk/+/15630/4/res/res_pjsip/pjsip_message_filter.c@242 
PS4, Line 242: 	if ((tdata->tp_info.transport->key.type != PJSIP_TRANSPORT_UDP) &&
> I think at the very least the behavior should not be the default, and if it is desired it should be behind an option. Changing such behavior can have unintended consequences.

I agree, by now I'm pretty sure it is not the desired behaviour :/

> As for the right direction to do this, I'm not actually sure. Using the transport itself will likely give the ephemeral port, so you'd need to get the information from the factory instead.

Thanks, I'll try to get the correct port from the transport's factory somehow.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15630
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I598e60257a7f92b29efce1fb3e9a2fc06f1439b6
Gerrit-Change-Number: 15630
Gerrit-PatchSet: 4
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Bernd Zobl <b.zobl at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 09:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Bernd Zobl <b.zobl at commend.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210402/79d5b502/attachment.html>