[Asterisk-code-review] res_aeap: Add basic config skeleton and CLI commands. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Apr 1 07:32:36 CDT 2021


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15699 )

Change subject: res_aeap: Add basic config skeleton and CLI commands.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15699/3/res/res_aeap.c 
File res/res_aeap.c:

https://gerrit.asterisk.org/c/asterisk/+/15699/3/res/res_aeap.c@105 
PS3, Line 105: 		ast_log(LOG_ERROR, "AEAP - Server URL must be present\n");
This should include the name of the object, or else it can be confusing for the user.


https://gerrit.asterisk.org/c/asterisk/+/15699/3/res/res_aeap.c@110 
PS3, Line 110: 		ast_log(LOG_ERROR, "AEAP - Server URL must be ws or wss\n");
This should include the name of the object, or else it can be confusing for the user.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15699
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I567ac5148c92b98d29d2ad83421b416b75ffdaa3
Gerrit-Change-Number: 15699
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 12:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210401/fd7be639/attachment.html>


More information about the asterisk-code-review mailing list