[Asterisk-code-review] pbx.c: On error, ast_add_extension2_lockopt should always free 'data' (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15021 )

Change subject: pbx.c: On error, ast_add_extension2_lockopt should always free 'data'
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15021/1/main/pbx.c 
File main/pbx.c:

https://gerrit.asterisk.org/c/asterisk/+/15021/1/main/pbx.c@7264 
PS1, Line 7264: 		/* We always need to deallocate 'data' on failure */
I think the documentation in pbx.h should be added to make this behavior aspect explicit



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15021
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I904707aae55169feda050a5ed7c6793b53fe6eae
Gerrit-Change-Number: 15021
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 30 Sep 2020 09:32:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200930/ab5bea1d/attachment.html>