[Asterisk-code-review] app_confbridge/bridge_softmix: Add ability to set max bitrate (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14939 )

Change subject: app_confbridge/bridge_softmix:  Add ability to set max bitrate
......................................................................


Patch Set 1: Code-Review-1

I think that the naming of this can end up being confusing. I think forced and maximum are two different things. If forced then you are explicitly set the maximum bitrate disregarding the information provided by each receiver. If maximum then you are enforcing a maximum that the bitrate can get to, while it can actually go below. This option is strictly forced and I think the use of "maximum" should be removed from its information and description.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14939
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idce6464ff014a37ea3b82944452e56cc4d75ab0a
Gerrit-Change-Number: 14939
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 29 Sep 2020 10:50:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200929/9da21e34/attachment.html>