[Asterisk-code-review] channels: Don't dereference NULL pointer (asterisk[16])

Jasper van der Neut asteriskteam at digium.com
Wed Sep 23 04:07:49 CDT 2020


Jasper van der Neut has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/14935 )


Change subject: channels: Don't dereference NULL pointer
......................................................................

channels: Don't dereference NULL pointer

Check result of ast_translator_build_path against NULL before dereferencing.

Change-Id: Ia3538ea190bd371f70c9dd49984b021765691b29
---
M main/channel.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/35/14935/1

diff --git a/main/channel.c b/main/channel.c
index 9c692d7..0f76c9b 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -5721,11 +5721,15 @@
 		if (!direction) {
 			/* reading */
 			trans_pvt = ast_translator_build_path(best_set_fmt, best_native_fmt);
-			trans_pvt->interleaved_stereo = 0;
+			if (trans_pvt) {
+				trans_pvt->interleaved_stereo = 0;
+			}
 		} else {
 			/* writing */
 			trans_pvt = ast_translator_build_path(best_native_fmt, best_set_fmt);
-			trans_pvt->interleaved_stereo = interleaved_stereo;
+			if (trans_pvt) {
+				trans_pvt->interleaved_stereo = interleaved_stereo;
+			}
 		}
 		access->set_trans(chan, trans_pvt);
 		res = trans_pvt ? 0 : -1;

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14935
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia3538ea190bd371f70c9dd49984b021765691b29
Gerrit-Change-Number: 14935
Gerrit-PatchSet: 1
Gerrit-Owner: Jasper van der Neut <jasper at isotopic.nl>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200923/7ec96904/attachment.html>


More information about the asterisk-code-review mailing list