[Asterisk-code-review] bridge_softmix/sfu_topologies_on_join: Ignore topology change failures (asterisk[16])

George Joseph asteriskteam at digium.com
Thu Sep 17 14:19:38 CDT 2020


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/14929

to look at the new patch set (#2).

Change subject: bridge_softmix/sfu_topologies_on_join: Ignore topology change failures
......................................................................

bridge_softmix/sfu_topologies_on_join: Ignore topology change failures

When a channel joins a bridge, we do topology change requests on all
existing channels to add the new participant to them.  However the
announcer channel will return an error because it doesn't support
topology in the first place.  Unfortunately, there doesn't seem to be a
reliable way to tell if the error is expected or not so the error is
ignored for all channels.  If the request fails on a "real" channel,
that channel just won't get the new participant's video.

Change-Id: Ic95db4683f27d224c1869fe887795d6b9fdea4f0
---
M bridges/bridge_softmix.c
1 file changed, 24 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/29/14929/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14929
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic95db4683f27d224c1869fe887795d6b9fdea4f0
Gerrit-Change-Number: 14929
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200917/d16b7fbb/attachment.html>


More information about the asterisk-code-review mailing list