[Asterisk-code-review] bridge_softmix/sfu_topologies_on_join: Ignore topology change failures (asterisk[certified/16.8])

Benjamin Keith Ford asteriskteam at digium.com
Thu Sep 17 13:55:29 CDT 2020


Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14966 )

Change subject: bridge_softmix/sfu_topologies_on_join: Ignore topology change failures
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Just minor typos, otherwise looks sane to me

https://gerrit.asterisk.org/c/asterisk/+/14966/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/14966/1//COMMIT_MSG@12 
PS1, Line 12: Unfoprtunately
s/Unfoprtunately/Unfortunately


https://gerrit.asterisk.org/c/asterisk/+/14966/1/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/c/asterisk/+/14966/1/bridges/bridge_softmix.c@683 
PS1, Line 683: 			SCOPE_EXIT_LOG_RTN(LOG_ERROR, "%s/%s: Couldn't apopend streams\n",
s/apepend/append



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14966
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: Ic95db4683f27d224c1869fe887795d6b9fdea4f0
Gerrit-Change-Number: 14966
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Thu, 17 Sep 2020 18:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200917/829bb56e/attachment.html>


More information about the asterisk-code-review mailing list