[Asterisk-code-review] Logging: Add debug logging categories (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14887 )

Change subject: Logging: Add debug logging categories
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/c/asterisk/+/14887/2/include/asterisk/logger_category.h 
File include/asterisk/logger_category.h:

https://gerrit.asterisk.org/c/asterisk/+/14887/2/include/asterisk/logger_category.h@178 
PS2, Line 178: /******************************************************************************
             :  * Category name, unique id and helper macros.
             :  *
             :  * These each really should be located in specific modules or core files, but in
             :  * order to ease management, and file inclusions they are located here for now.
             :  *****************************************************************************/
I wouldn't set the precedent by leaving them here.  Putting them in the modules now will ensure that we don't make this unweildy.


https://gerrit.asterisk.org/c/asterisk/+/14887/2/main/cli.c 
File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/14887/2/main/cli.c@a594 
PS2, Line 594: 
I'd leave this blank line in for readability.


https://gerrit.asterisk.org/c/asterisk/+/14887/2/main/cli.c@1552 
PS2, Line 1552: for 
delete


https://gerrit.asterisk.org/c/asterisk/+/14887/2/main/cli.c@1552 
PS2, Line 1552:  of 
Delete


https://gerrit.asterisk.org/c/asterisk/+/14887/2/main/logger_category.c 
File main/logger_category.c:

https://gerrit.asterisk.org/c/asterisk/+/14887/2/main/logger_category.c@267 
PS2, Line 267: 	ast_debug_category_register(AST_LOG_CATEGORY_RTP, AST_DEBUG_CATEGORY_RTP);
             : 	ast_debug_category_register(AST_LOG_CATEGORY_RTP_PACKET, AST_DEBUG_CATEGORY_RTP_PACKET);
             : 
             : 	ast_debug_category_register(AST_LOG_CATEGORY_RTCP, AST_DEBUG_CATEGORY_RTCP);
             : 	ast_debug_category_register(AST_LOG_CATEGORY_RTCP_PACKET, AST_DEBUG_CATEGORY_RTCP_PACKET);
             : 
             : 	ast_debug_category_register(AST_LOG_CATEGORY_DTLS, AST_DEBUG_CATEGORY_DTLS);
             : 	ast_debug_category_register(AST_LOG_CATEGORY_DTLS_PACKET, AST_DEBUG_CATEGORY_DTLS_PACKET);
             : 
             : 	ast_debug_category_register(AST_LOG_CATEGORY_STUN, AST_DEBUG_CATEGORY_STUN);
             : 	ast_debug_category_register(AST_LOG_CATEGORY_STUN_PACKET, AST_DEBUG_CATEGORY_STUN_PACKET);
             : 
             : 	ast_debug_category_register(AST_LOG_CATEGORY_ICE, AST_DEBUG_CATEGORY_ICE);
I think these should be done by the modules.  If left here it could potentially grow to a very large number.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14887
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6e6cb247bb1f01dbf34750b2cd98e5b5b41a1849
Gerrit-Change-Number: 14887
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 01 Sep 2020 12:46:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200901/f7dcc771/attachment-0001.html>