[Asterisk-code-review] res_stir_shaken: Include OpenSSL headers where used actually. (asterisk[master])

Alexander Traud asteriskteam at digium.com
Fri Oct 30 10:06:07 CDT 2020


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15124 )

Change subject: res_stir_shaken: Include OpenSSL headers where used actually.
......................................................................


Patch Set 1:

That fixes my own change Idba515. By the way for new modules like this, please, use tools like iwyu (see ASTERISK-25591). That reviews the header inclusions automatically. For example, res/res_stir_shaken/certificate.c is still "wrong" because that file includes EVP not explicitly but implicitly via its own header.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15124
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6a07e2d81d2b5442e24e99b8cc733a99f881dcf4
Gerrit-Change-Number: 15124
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Fri, 30 Oct 2020 15:06:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201030/2d7d3852/attachment.html>


More information about the asterisk-code-review mailing list