[Asterisk-code-review] Compiler fixes for GCC with -Og (asterisk[master])

George Joseph asteriskteam at digium.com
Fri Oct 30 06:43:47 CDT 2020


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15077 )

Change subject: Compiler fixes for GCC with -Og
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15077/2/apps/app_directory.c 
File apps/app_directory.c:

https://gerrit.asterisk.org/c/asterisk/+/15077/2/apps/app_directory.c@416 
PS2, Line 416: 				char buf[7+12]; /* INT_MIN has a length of 12 chars */
Doesn't moving this here cause it to get re-allocated every time?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15077
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2a72c072083b4492a223c6f9d73d21f4f424db62
Gerrit-Change-Number: 15077
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 30 Oct 2020 11:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201030/3b3ea257/attachment.html>


More information about the asterisk-code-review mailing list