[Asterisk-code-review] main/say: Work around gcc 9 format-truncation false positive (asterisk[13])

Alexander Traud asteriskteam at digium.com
Thu Oct 29 04:24:13 CDT 2020


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14501 )

Change subject: main/say: Work around gcc 9 format-truncation false positive
......................................................................


Patch Set 1:

Yepp, and now we aka you have to give it to the GCC community for review.

Anyway, George did not answer and nobody else of the Asterisk team moderated either. Therefore, force a re-review by changing your commit. For example, I would not use '10' or '12' but 'sizeof(buf)' in the snprintf as used normally within Asterisk.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14501
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic7a70120188c9aa525a6d70289385bfce878438a
Gerrit-Change-Number: 14501
Gerrit-PatchSet: 1
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 09:24:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201029/fc9492a4/attachment-0001.html>


More information about the asterisk-code-review mailing list