[Asterisk-code-review] Mofified funcs/func_curl.c so that we can set what constitutes a fai... (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15066 )

Change subject: Mofified funcs/func_curl.c so that we can set what constitutes a  failure for curl requests for instance a 404 or 503. This is for ASTERISK-28825
......................................................................


Patch Set 4: Code-Review-1

(5 comments)

Only the commit message really needs to be corrected.  The coding guideline spacing is less important but should be corrected.

https://gerrit.asterisk.org/c/asterisk/+/15066/4//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15066/4//COMMIT_MSG@7 
PS4, Line 7: Mofified funcs/func_curl.c so that we can set what constitutes a
Please follow the commit message format shown on the wiki:

https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/c/asterisk/+/15066/4/funcs/func_curl.c 
File funcs/func_curl.c:

https://gerrit.asterisk.org/c/asterisk/+/15066/4/funcs/func_curl.c@704 
PS4, Line 704: 		} else if (cur->key == CURLOPT_SPECIAL_FAILURE_CODE) {
Code guidelines: spacing around operators in this change block


https://gerrit.asterisk.org/c/asterisk/+/15066/4/funcs/func_curl.c@727 
PS4, Line 727: 				} else if (cur->key == CURLOPT_SPECIAL_FAILURE_CODE) {
Code guidelines: spacing around operators in this change block


https://gerrit.asterisk.org/c/asterisk/+/15066/4/funcs/func_curl.c@766 
PS4, Line 766: 	ast_log(LOG_NOTICE, "CURL response code (%ld).\n",http_code);
Code guidelines: spacing around operators in this change block


https://gerrit.asterisk.org/c/asterisk/+/15066/4/funcs/func_curl.c@1007 
PS4, Line 1007: 
Extraneous blank line added



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15066
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I94443e508343e0a3e535e51ea6e0562767639987
Gerrit-Change-Number: 15066
Gerrit-PatchSet: 4
Gerrit-Owner: Dovid Bender <dovid at telecurve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 28 Oct 2020 18:29:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201028/f1fd50a5/attachment-0001.html>