[Asterisk-code-review] main/say: Work around gcc 9 format-truncation false positive (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14501 )

Change subject: main/say: Work around gcc 9 format-truncation false positive
......................................................................


Patch Set 1:

If -O0 and -Og do not face that issue, an expected False Positive sounds likely. I would start a discussion with a GCC guy whether it is worth further investigation. Unfortunately, I am not aware of anyone in the Asterisk team or within the regular Asterisk contributors who is into GCC. Recently, there was an issue for sure with one of the optimizations of -O3. Instead of investigating with the GCC community, a may-not-related bug found somehow was used as justification to disable that optimization.

At the end, it is ‘our’ job to create a minimal example and then hook-up with the GCC community. Go figure! In my -Og cases, I really consider that because those are really crazy ones (although they have terrible easy workarounds like yours here). George, why do you block this here?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14501
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic7a70120188c9aa525a6d70289385bfce878438a
Gerrit-Change-Number: 14501
Gerrit-PatchSet: 1
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Wed, 28 Oct 2020 13:39:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201028/69858d57/attachment.html>