[Asterisk-code-review] voicemail: add option 'e' top play greetings as early media (asterisk[17])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15065 )

Change subject: voicemail: add option 'e' top play greetings as early media
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

This needs a CHANGES entry as well[1].

[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt

https://gerrit.asterisk.org/c/asterisk/+/15065/5/apps/app_voicemail.c 
File apps/app_voicemail.c:

https://gerrit.asterisk.org/c/asterisk/+/15065/5/apps/app_voicemail.c@12357 
PS5, Line 12357: 			ast_log(AST_LOG_NOTICE, "Playing greetings as Early Media, deferring answer\n");
I don't think a notice is really warranted here



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15065
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I41b9f0428783c0bd697c8c994f906d1e75ce9ddb
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 5
Gerrit-Owner: Juan Carlos Castro y Castro <jccyc1965 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 27 Oct 2020 10:45:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201027/4746698e/attachment.html>