[Asterisk-code-review] voicemail: add option 'e' top play greetings as early media (asterisk[17])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15065 )

Change subject: voicemail: add option 'e' top play greetings as early media
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15065/2/apps/app_voicemail.c 
File apps/app_voicemail.c:

https://gerrit.asterisk.org/c/asterisk/+/15065/2/apps/app_voicemail.c@6914 
PS2, Line 6914: if (ast_channel_state(chan) != AST_STATE_UP)
              : 		ast_answer(chan);
I know you've only moved this code, but all blocks should have braces, so you can add them here.


https://gerrit.asterisk.org/c/asterisk/+/15065/2/apps/app_voicemail.c@12356 
PS2, Line 12356: 			ast_log(AST_LOG_WARNING, "Playing greetings as Early Media, deferring answer (EXPERIMENTAL FEATURE)\n");
If it's experimental it shouldn't be going into release branches. If it works (you've tested) then this could be a NOTICE (or maybe even a debug?) and you can remove the 'experimental feature' part.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15065
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I41b9f0428783c0bd697c8c994f906d1e75ce9ddb
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 2
Gerrit-Owner: Juan Carlos Castro y Castro <jccyc1965 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 16 Oct 2020 20:26:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201016/19ed7e8e/attachment.html>