[Asterisk-code-review] res_pjsip: Replace calls to ast_sip_message_apply_transport after bei... (asterisk[master])
Richard Mudgett
asteriskteam at digium.com
Wed Oct 14 09:34:53 CDT 2020
Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15063 )
Change subject: res_pjsip: Replace calls to ast_sip_message_apply_transport after being accidentally removed
......................................................................
Patch Set 1:
(1 comment)
The commit message can use some updating.
https://gerrit.asterisk.org/c/asterisk/+/15063/1//COMMIT_MSG
Commit Message:
https://gerrit.asterisk.org/c/asterisk/+/15063/1//COMMIT_MSG@9
PS1, Line 9: Commit 44bb0858cb3ea6a8db8b8d1c7fedcfec341ddf66 ("debugging: Add enough to choke a mule") accidentally removed calls to ast_sip_message_apply_transport when it was attempting to just add debugging code.
It would be nice to word wrap the commit message at column 75.
https://wiki.asterisk.org/wiki/display/AST/Commit+Messages
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15063
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0f3e32c2e8ac415e30b1d29966d75a1546f0526a
Gerrit-Change-Number: 15063
Gerrit-PatchSet: 1
Gerrit-Owner: Nick French <nickfrench at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 14:34:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201014/a779133a/attachment.html>
More information about the asterisk-code-review
mailing list