[Asterisk-code-review] res_pjsip: Replace calls to ast_sip_message_apply_transport after bei... (asterisk[master])

Nick French asteriskteam at digium.com
Tue Oct 13 12:23:19 CDT 2020


Nick French has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/15063 )


Change subject: res_pjsip: Replace calls to ast_sip_message_apply_transport after being accidentally removed
......................................................................

res_pjsip: Replace calls to ast_sip_message_apply_transport after being accidentally removed

Commit 44bb0858cb3ea6a8db8b8d1c7fedcfec341ddf66 ("debugging: Add enough to choke a mule") accidentally removed calls to ast_sip_message_apply_transport when it was attempting to just add debugging code.

The kiss of death was saying that there were no functional changes in the commit comment

This makes outbound calls that use the 'flow' transport mechanism fail, since this call is used to relay headers into the outbound INVITE requests.

ASTERISK-29124 #close

Change-Id: I0f3e32c2e8ac415e30b1d29966d75a1546f0526a
---
M res/res_pjsip_session.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/63/15063/1

diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c
index 42edaf6..82234aa 100644
--- a/res/res_pjsip_session.c
+++ b/res/res_pjsip_session.c
@@ -4388,6 +4388,8 @@
 	SCOPE_ENTER(3, "%s: Method is %.*s\n", ast_sip_session_get_name(session),
 		(int) pj_strlen(&req.method.name), pj_strbuf(&req.method.name));
 
+	ast_sip_message_apply_transport(session->endpoint->transport, tdata);
+
 	AST_LIST_TRAVERSE(&session->supplements, supplement, next) {
 		if (supplement->outgoing_request && does_method_match(&req.method.name, supplement->method)) {
 			supplement->outgoing_request(session, tdata);
@@ -4412,6 +4414,8 @@
 			ast_sip_session_get_name(session));
 	}
 
+	ast_sip_message_apply_transport(session->endpoint->transport, tdata);
+
 	AST_LIST_TRAVERSE(&session->supplements, supplement, next) {
 		if (supplement->outgoing_response && does_method_match(&cseq->method.name, supplement->method)) {
 			supplement->outgoing_response(session, tdata);

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15063
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0f3e32c2e8ac415e30b1d29966d75a1546f0526a
Gerrit-Change-Number: 15063
Gerrit-PatchSet: 1
Gerrit-Owner: Nick French <nickfrench at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201013/e033e10c/attachment.html>


More information about the asterisk-code-review mailing list