[Asterisk-code-review] res_pjsip: Adjust outgoing offer call pref. (asterisk[18])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15040 )

Change subject: res_pjsip: Adjust outgoing offer call pref.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > I think it's really confusing having 6 options affecting codecs, 4 of which are ignored.
> > I'll let other chime in though.
> 
> *looks around* So far this default change seems to have been the only issue, provided things operate as before I don't think it's that much of an issue.

We could also remove it from the sample config, and add an explicit note to the XML documentation about being reserved for future functionality.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15040
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Iad19347bd5f3d89900c15ecddfebf5e20950a1c2
Gerrit-Change-Number: 15040
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 13:18:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201012/08347960/attachment.html>