[Asterisk-code-review] sched: AST_SCHED_REPLACE_UNREF can leads to use after free of data (asterisk[16])

Richard Mudgett asteriskteam at digium.com
Sat Oct 3 08:35:55 CDT 2020


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15038 )

Change subject: sched: AST_SCHED_REPLACE_UNREF can leads to use after free of data
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/15038/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15038/1//COMMIT_MSG@7 
PS1, Line 7: sched: AST_SCHED_REPLACE_UNREF can leads to use after free of data
s/can leads/can lead/


https://gerrit.asterisk.org/c/asterisk/+/15038/1//COMMIT_MSG@10 
PS1, Line 10: 'data'. Because at first the object is unreferenced wihch can leads to
typo: wihch
s/can leads/can lead/


https://gerrit.asterisk.org/c/asterisk/+/15038/1//COMMIT_MSG@11 
PS1, Line 11: destroy it.
s/destroy/destroying/



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15038
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I0164f57c387243510bdbd2f8dcf33377b6c202da
Gerrit-Change-Number: 15038
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sat, 03 Oct 2020 13:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201003/10ad7be9/attachment-0001.html>


More information about the asterisk-code-review mailing list