[Asterisk-code-review] res_pjsip_stir_shaken: Fix module description (asterisk[16])

Stanislav Abramenkov asteriskteam at digium.com
Mon Nov 23 14:07:37 CST 2020


Hello Alexander Traud,

I'd like you to do a code review. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/15201

to review the following change.


Change subject: res_pjsip_stir_shaken: Fix module description
......................................................................

res_pjsip_stir_shaken: Fix module description

the 'J' is missing in module description.
"PSIP STIR/SHAKEN Module for Asterisk" -> "PJSIP STIR/SHAKEN Module for Asterisk"

ASTERISK-29175
w

Change-Id: I7795f8eb91a3cd16b7d6c5ccf2884a97fb051183
---
M funcs/func_odbc.c
M funcs/func_periodic_hook.c
M res/res_hep_pjsip.c
M res/res_odbc.c
M res/res_pjproject.c
M res/res_pjsip.c
M res/res_pjsip_stir_shaken.c
M tests/test_http_media_cache.c
8 files changed, 10 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/01/15201/1

diff --git a/funcs/func_odbc.c b/funcs/func_odbc.c
index acebdcc..5cc0faa 100644
--- a/funcs/func_odbc.c
+++ b/funcs/func_odbc.c
@@ -1947,4 +1947,5 @@
 	.load = load_module,
 	.unload = unload_module,
 	.reload = reload,
+	.requires = "res_odbc",
 );
diff --git a/funcs/func_periodic_hook.c b/funcs/func_periodic_hook.c
index 31c534c..e38ff3e 100644
--- a/funcs/func_periodic_hook.c
+++ b/funcs/func_periodic_hook.c
@@ -519,4 +519,5 @@
 	.support_level = AST_MODULE_SUPPORT_CORE,
 	.load = load_module,
 	.unload = unload_module,
+	.requires = "app_chanspy,func_cut,func_groupcount,func_uri",
 );
diff --git a/res/res_hep_pjsip.c b/res/res_hep_pjsip.c
index be2f6ea..b1a0377 100644
--- a/res/res_hep_pjsip.c
+++ b/res/res_hep_pjsip.c
@@ -251,5 +251,5 @@
 	.support_level = AST_MODULE_SUPPORT_EXTENDED,
 	.load = load_module,
 	.unload = unload_module,
-	.requires = "res_hep,res_pjsip",
+	.requires = "res_pjsip,res_pjsip_session,res_hep",
 );
diff --git a/res/res_odbc.c b/res/res_odbc.c
index da8700d..0dc8124 100644
--- a/res/res_odbc.c
+++ b/res/res_odbc.c
@@ -1143,4 +1143,5 @@
 	.unload = unload_module,
 	.reload = reload,
 	.load_pri = AST_MODPRI_REALTIME_DEPEND,
+	.requires = "res_odbc_transaction",
 );
diff --git a/res/res_pjproject.c b/res/res_pjproject.c
index 2bb5d3b..f6dce4c 100644
--- a/res/res_pjproject.c
+++ b/res/res_pjproject.c
@@ -34,6 +34,7 @@
 
 /*** MODULEINFO
 	<depend>pjproject</depend>
+	<depend>res_sorcery_config</depend>
 	<support_level>core</support_level>
  ***/
 
@@ -767,4 +768,5 @@
 	.unload = unload_module,
 	.reload = reload_module,
 	.load_pri = AST_MODPRI_CHANNEL_DEPEND - 6,
+	.requires = "res_sorcery_config",
 );
diff --git a/res/res_pjsip.c b/res/res_pjsip.c
index 094ae7f..b82847a 100644
--- a/res/res_pjsip.c
+++ b/res/res_pjsip.c
@@ -5429,6 +5429,6 @@
 	.unload = unload_module,
 	.reload = reload_module,
 	.load_pri = AST_MODPRI_CHANNEL_DEPEND - 5,
-	.requires = "dnsmgr,res_pjproject",
+	.requires = "dnsmgr,res_pjproject,res_sorcery_config,res_sorcery_memory,res_sorcery_astdb",
 	.optional_modules = "res_statsd",
 );
diff --git a/res/res_pjsip_stir_shaken.c b/res/res_pjsip_stir_shaken.c
index 24d3670..12d68e4 100644
--- a/res/res_pjsip_stir_shaken.c
+++ b/res/res_pjsip_stir_shaken.c
@@ -323,10 +323,10 @@
 #define AST_BUILDOPT_SUM ""
 
 AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_GLOBAL_SYMBOLS | AST_MODFLAG_LOAD_ORDER,
-				"PSIP STIR/SHAKEN Module for Asterisk",
+				"PJSIP STIR/SHAKEN Module for Asterisk",
 	.support_level = AST_MODULE_SUPPORT_CORE,
 	.load = load_module,
 	.unload = unload_module,
 	.load_pri = AST_MODPRI_DEFAULT,
-	.requires = "res_pjsip,res_stir_shaken",
+	.requires = "res_pjsip,res_pjsip_session,res_stir_shaken",
 );
diff --git a/tests/test_http_media_cache.c b/tests/test_http_media_cache.c
index 2a3398f..c197539 100644
--- a/tests/test_http_media_cache.c
+++ b/tests/test_http_media_cache.c
@@ -697,4 +697,5 @@
 		.load = load_module,
 		.reload = reload_module,
 		.unload = unload_module,
+		.requires = "res_http_media_cache",
 	);

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15201
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7795f8eb91a3cd16b7d6c5ccf2884a97fb051183
Gerrit-Change-Number: 15201
Gerrit-PatchSet: 1
Gerrit-Owner: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201123/f94f4ba9/attachment.html>


More information about the asterisk-code-review mailing list