[Asterisk-code-review] bridge_basic: Fixed setup of recall channels (asterisk[18])

George Joseph asteriskteam at digium.com
Wed Nov 18 10:12:53 CST 2020


George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/15183 )

Change subject: bridge_basic: Fixed setup of recall channels
......................................................................

bridge_basic: Fixed setup of recall channels

Fixed a bug (like a typo) in retransfer_enter()
at main/bridge_basic.c:2641. common_recall_channel_setup() setups
common things on the recalled transfer target, but used same target
as source instead trasfered.

ASTERISK-29161 #close

Change-Id: Ieb549654a621c38b1ad5e9d15b9f18823d9cc31f
---
M main/bridge_basic.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, approved
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, but someone else must approve; Approved for Submit



diff --git a/main/bridge_basic.c b/main/bridge_basic.c
index 284d178..21b4b0e 100644
--- a/main/bridge_basic.c
+++ b/main/bridge_basic.c
@@ -2638,7 +2638,7 @@
 		&props->original_transferer_colp);
 	ast_party_id_reset(&ast_channel_connected(props->recall_target)->priv);
 
-	common_recall_channel_setup(props->recall_target, props->recall_target);
+	common_recall_channel_setup(props->recall_target, props->transferer);
 	ast_channel_unlock(props->recall_target);
 	ast_channel_unlock(props->transferer);
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15183
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ieb549654a621c38b1ad5e9d15b9f18823d9cc31f
Gerrit-Change-Number: 15183
Gerrit-PatchSet: 2
Gerrit-Owner: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201118/f9aa28f2/attachment-0001.html>


More information about the asterisk-code-review mailing list