[Asterisk-code-review] Introduce astcachedir, to be used for temporary bucket files (asterisk[16])

lvl asteriskteam at digium.com
Thu Nov 12 06:07:57 CST 2020


lvl has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15076 )

Change subject: Introduce astcachedir, to be used for temporary bucket files
......................................................................


Patch Set 2:

> Patch Set 1: Code-Review-1
> 
> Needs a CHANGES entry I think.  Other than that, I'm OK with this for 16 and 18.  For master, I'd make the default LOCALSTATEDIR/cache/asterisk (/var/cache/asterisk) and update the Makefile to create that directory on install if needed and remove it on uninstall-all (not plain uninstall).

I added an entry for CHANGES, and will cherry-pick to 18.

Should this be cherry-picked to master as well and then switched to /var/ in a separate change request?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15076
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic54e95199405abacd9e509cef5f08fa14c510b5d
Gerrit-Change-Number: 15076
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 12 Nov 2020 12:07:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201112/e60339da/attachment.html>


More information about the asterisk-code-review mailing list