[Asterisk-code-review] res_pjsip_outbound_registration.c: Use our own scheduler and other s... (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15130 )

Change subject: res_pjsip_outbound_registration.c:  Use our own scheduler and other stuff
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15130/3/res/res_pjsip_outbound_registration.c 
File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/15130/3/res/res_pjsip_outbound_registration.c@2267 
PS3, Line 2267: 	unregister_all();
> Why was this added? The ao2_global_obj_release below should result in all states being unlinked and the same thing happening.

That's a very good question.  It was a hold-over from testing. 😊  If timer_b is greater than the MAX_UNLOAD_TIMEOUT_TIME (35 seconds) then the shutdown group join will wait the full 35 seconds then spit out the "Module could not be unloaded..." message on graceful shutdown.  I was testing mitigation methods and forgot to remove this call.  Will do so now.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15130
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4534a0fc78c7cb69f23b7b449dda9748c90daca2
Gerrit-Change-Number: 15130
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 10 Nov 2020 14:05:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201110/6adcb4fe/attachment.html>