[Asterisk-code-review] res_pjsip_logger.c: correct the return value checks when writing to p... (asterisk[16])

nappsoft asteriskteam at digium.com
Fri May 29 13:11:27 CDT 2020


Hello Sean Bright, Joshua Colp, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/14449

to look at the new patch set (#3).

Change subject: res_pjsip_logger.c: correct the return value checks when writing to pcap files
......................................................................

res_pjsip_logger.c: correct the return value checks when writing to pcap
files

fwrite() does return the number of elements written and not the
number of bytes. However asterisk is currently comparing the return
value to the size of the written element what means that asterisk logs
five WARNING messages on every packet written to the pcap file.

This patch changes the code to check for the correct value, which will
always be 1.

ASTERISK-28921 #close

Change-Id: I2455032d9cb4c5a500692923f9e2a22e68b08fc2
---
M res/res_pjsip_logger.c
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/49/14449/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14449
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2455032d9cb4c5a500692923f9e2a22e68b08fc2
Gerrit-Change-Number: 14449
Gerrit-PatchSet: 3
Gerrit-Owner: nappsoft <infos at nappsoft.ch>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200529/9fd42348/attachment.html>


More information about the asterisk-code-review mailing list