[Asterisk-code-review] Scope Tracing: A new facility for tracing scope enter/exit (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14463 )

Change subject: Scope Tracing:  A new facility for tracing scope enter/exit
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14463/2/main/logger.c 
File main/logger.c:

https://gerrit.asterisk.org/c/asterisk/+/14463/2/main/logger.c@2296 
PS2, Line 2296: 	struct ast_str *fmt = ast_str_create(128);
> Just curios why you switched this to a heap allocated object?

When it was stack based, there was an issue reallocating the backing storage when it needed to be expanded.  It's on my "investigate later" list.


https://gerrit.asterisk.org/c/asterisk/+/14463/2/main/logger.c@2298 
PS2, Line 2298: 
> check that fmt != NULL before continuing.
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14463
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic5ebb859883f9c10a08c5630802de33500cad027
Gerrit-Change-Number: 14463
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 29 May 2020 13:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200529/0977ba57/attachment.html>