[Asterisk-code-review] pjproject: Upgrade bundled version to pjproject 2.10 (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14413 )

Change subject: pjproject: Upgrade bundled version to pjproject 2.10
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14413/3/res/res_pjsip_outbound_publish.c 
File res/res_pjsip_outbound_publish.c:

https://gerrit.asterisk.org/c/asterisk/+/14413/3/res/res_pjsip_outbound_publish.c@1323 
PS3, Line 1323: 		if (!expires || !expires || expires->ivalue == PJSIP_EXPIRES_NOT_SPECIFIED) {
Expression still messed up.  !expires is duplicated.  Still don't think the expression is equivalent between old and new pjproject versions.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Iec8821c6cbbc08c369d0e3cd2f14e691b41d0c81
Gerrit-Change-Number: 14413
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 19 May 2020 18:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200519/741b1670/attachment.html>